There's no need to check that the document is valid here in modifier_add_to_set.cpp when there are similar checks done higher up in exec/update.cpp: different function storageValid used here
----------------
BSONObj::storageValid and BSONObj::storageValidEmbedded were moved from the modifier_* files into ops/update.cpp in this commit.
These eventually ended up in exec/update.cpp, moved from ops/update.cpp, by this commit. New storage validation checks were implemented that no longer used BSONObj::storageValid, somewhere between the two commits.
modifier_add_to_set.cpp still using BSONObj::storageValid seems like an oversight.
-----------------
This task is part of resolving SERVER-29334 (cleanup). modifier_add_to_set.cpp is a redundant use of BSONObj::storageValidEmbedded, which SERVER-29334 must modify.
- is depended on by
-
SERVER-29334 Cannot write shard chunks documents with _id fields containing values with dotted field names, e.g. { _id: { a.b: 10 } }
-
- Closed
-