Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-29351

remove redundant use of BSONObj::storageValidEmbedded from modifier_add_to_set.cpp

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5.9
    • Component/s: Sharding
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Sprint:
      Sharding 2017-05-29, Sharding 2017-06-19

      Description

      There's no need to check that the document is valid here in modifier_add_to_set.cpp when there are similar checks done higher up in exec/update.cpp: different function storageValid used here

      ----------------

      BSONObj::storageValid and BSONObj::storageValidEmbedded were moved from the modifier_* files into ops/update.cpp in this commit.

      These eventually ended up in exec/update.cpp, moved from ops/update.cpp, by this commit. New storage validation checks were implemented that no longer used BSONObj::storageValid, somewhere between the two commits.

      modifier_add_to_set.cpp still using BSONObj::storageValid seems like an oversight.

      -----------------

      This task is part of resolving SERVER-29334 (cleanup). modifier_add_to_set.cpp is a redundant use of BSONObj::storageValidEmbedded, which SERVER-29334 must modify.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dianna.hohensee Dianna Hohensee
              Reporter:
              dianna.hohensee Dianna Hohensee
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: