[SERVER-29374] Remove massert check on numIndexesInProgress() from IndexCatalog::dropAllIndexes() - MongoDB Jira

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Major - P3
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 4.3.1
Component/s: Storage
Labels:
- neweng

Backwards Compatibility:
Fully Compatible
Sprint:
Execution Team 2019-09-09

Description

Currently, IndexCatalog::dropAllIndexes() does both a check on background operations on the collection and indexes that are still in the process of being built:

Since the only possible background operation is an index build, the check on the in-progress indexes may be redundant.

https://github.com/mongodb/mongo/blob/ff2cf3e560c4768f88c9911d09d8fa60526911dc/src/mongo/db/catalog/index_catalog_impl.cpp#L864


void IndexCatalogImpl::dropAllIndexes(OperationContext* opCtx,
                                      bool includingIdIndex,
                                      std::map<std::string, BSONObj>* droppedIndexes) {
    invariant(opCtx->lockState()->isCollectionLockedForMode(_collection->ns().toString(), MODE_X));
 
    BackgroundOperation::assertNoBgOpInProgForNs(_collection->ns().ns());
 
    // there may be pointers pointing at keys in the btree(s).  kill them.
    // TODO: can this can only clear cursors on this index?
    _collection->getCursorManager()->invalidateAll(
        opCtx, false, "all indexes on collection dropped");
 
    // make sure nothing in progress
    massert(17348,
            "cannot dropAllIndexes when index builds in progress",
            numIndexesTotal(opCtx) == numIndexesReady(opCtx));

Attachments

Issue Links

is related to

SERVER-29274 Two Phase Drops: rename collection to special drop-pending name

Closed

Activity

People

Assignee:: Haley Connelly

Reporter:: Benety Goh

Participants:: Benety Goh, Geert Bosch, Githook User, Haley Connelly, Sara Williamson

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: May 25 2017 05:26:01 PM UTC

Updated:: Sep 03 2019 04:19:23 PM UTC

Resolved:: Sep 03 2019 04:19:23 PM UTC

index_catalog_impl.cpp
851	void IndexCatalogImpl::dropAllIndexes(OperationContext* opCtx,
852	bool includingIdIndex,
853	std::map<std::string, BSONObj>* droppedIndexes) {
854	invariant(opCtx->lockState()->isCollectionLockedForMode(_collection->ns().toString(), MODE_X));
855
856	BackgroundOperation::assertNoBgOpInProgForNs(_collection->ns().ns());
857
858	// there may be pointers pointing at keys in the btree(s). kill them.
859	// TODO: can this can only clear cursors on this index?
860	_collection->getCursorManager()->invalidateAll(
861	opCtx, false, "all indexes on collection dropped");
862
863	// make sure nothing in progress
864	massert(17348,
865	"cannot dropAllIndexes when index builds in progress",
866	numIndexesTotal(opCtx) == numIndexesReady(opCtx));