Details
-
Bug
-
Resolution: Duplicate
-
Minor - P4
-
None
-
None
-
None
-
ALL
Description
The IDL-generated parser code already has StringData constants for the field names, but the parse method uses string literals directly. Seems like it should be using these constants instead.
For example:
constexpr StringData WriteOpTxnInfo::kStmtIdsFieldName;
|
constexpr StringData WriteOpTxnInfo::kTxnNumFieldName;
|
...
|
if (fieldName == "txnNum") {
|
if (ctxt.checkAndAssertType(element, NumberLong)) {
|
_txnNum = element._numberLong();
|
}
|
}
|
else if (fieldName == "stmtIds") {
|
std::uint32_t expectedFieldNumber{0};
|
...
|
Attachments
Issue Links
- duplicates
-
SERVER-29404 Performance pass of IDL generated code
-
- Closed
-