Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-29874

Two Phase Drops: dropDatabase does not work with applyOps

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.5.10
    • Component/s: Replication
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Epic Link:
    • Sprint:
      Repl 2017-07-31

      Description

      Since SERVER-29277, the dropDatabase waits for all collection drops to complete before removing the entry for the database from the catalog. To do this, the free function mongo::dropDatabase() needs to call either ReplicationCoordinator::awaitReplicationOfLastOpForClient() or ReplicationCoordinator::awaitReplication(). However, these functions fail when dropDatabase() is called from within an applyOps operation because applyOps executes all its given operations while holding the global lock.

      To reproduce:

      db.adminCommand({applyOps: [{op: 'c', ns: 'test.$cmd', o: {create: 't'}}, {op: 'c', ns: 'test.$cmd', o: {drop: 't'}}, {op: 'c', ns: 'test.$cmd', o: {dropDatabase: 1}}]})

        Attachments

          Issue Links

          is related to

          Task - A task that needs to be done. SERVER-29277 Two Phase Drops: implement dropDatabase changes to support 2-phase drops

          • Major - P3 - Major loss of function.
          • Closed
          related to

          Bug - A problem which impairs or prevents the functions of the product. SERVER-31436 dropDatabase must check `ReplicationCoordinator::canAcceptWritesFor` after reacquiring global lock

          • Major - P3 - Major loss of function.
          • Closed

          Task - A task that needs to be done. SERVER-43458 Remove TempRelease in dropDatabase

          • Major - P3 - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-29802 Non-atomic applyOps command should not take out a global exclusive lock

          • Major - P3 - Major loss of function.
          • Closed

            Activity

              People

              Assignee:
              benety.goh Benety Goh
              Reporter:
              benety.goh Benety Goh
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: