Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-30755

KeyError "selector" is raised when no tests or test suites specified to resmoke.py

    • Fully Compatible
    • ALL
    • Hide
      $ python buildscripts/resmoke.py 
      [resmoke] 2017-08-21T08:44:53.369-0400 resmoke.py invocation: buildscripts/resmoke.py
      Traceback (most recent call last):
        File "buildscripts/resmoke.py", line 186, in <module>
          main()
        File "buildscripts/resmoke.py", line 141, in main
          suites = resmokelib.parser.get_suites(values, args)
        File "/Users/maxh/debugging/mongo/buildscripts/resmokelib/parser.py", line 364, in get_suites
          suite = testing.suite.Suite(suite_filename, suite_config)
        File "/Users/maxh/debugging/mongo/buildscripts/resmokelib/testing/suite.py", line 31, in __init__
          self.tests = self._get_tests_for_kind(self.test_kind)
        File "/Users/maxh/debugging/mongo/buildscripts/resmokelib/testing/suite.py", line 52, in _get_tests_for_kind
          test_info = self.get_selector_config()
        File "/Users/maxh/debugging/mongo/buildscripts/resmokelib/testing/suite.py", line 86, in get_selector_config
          return self._suite_config["selector"]
      KeyError: 'selector'
      
      Show
      $ python buildscripts/resmoke.py [resmoke] 2017-08-21T08:44:53.369-0400 resmoke.py invocation: buildscripts/resmoke.py Traceback (most recent call last): File "buildscripts/resmoke.py", line 186, in <module> main() File "buildscripts/resmoke.py", line 141, in main suites = resmokelib.parser.get_suites(values, args) File "/Users/maxh/debugging/mongo/buildscripts/resmokelib/parser.py", line 364, in get_suites suite = testing.suite.Suite(suite_filename, suite_config) File "/Users/maxh/debugging/mongo/buildscripts/resmokelib/testing/suite.py", line 31, in __init__ self.tests = self._get_tests_for_kind(self.test_kind) File "/Users/maxh/debugging/mongo/buildscripts/resmokelib/testing/suite.py", line 52, in _get_tests_for_kind test_info = self.get_selector_config() File "/Users/maxh/debugging/mongo/buildscripts/resmokelib/testing/suite.py", line 86, in get_selector_config return self._suite_config["selector"] KeyError: 'selector'
    • TIG 2017-12-04
    • 0

      Prior to the changes from SERVER-28636, invoking python buildscripts/resmoke.py would caused a "Must specify either --suites or a list of tests" error. We should either restore this behavior by (a) detecting when --suites hasn't been specified (it currently defaults to with_server.yml and args is an empty list), or (b) changing the with_server.yml and no_server.yml YAML suite configurations to specify

      selector: 
        roots: []
      

      and have resmoke.py log "No tests ran" when invoking python buildscripts/resmoke.py.

            Assignee:
            jonathan.abrahams Jonathan Abrahams
            Reporter:
            max.hirschhorn@mongodb.com Max Hirschhorn
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: