Details
-
Improvement
-
Status: Closed
-
Major - P3
-
Resolution: Won't Fix
-
None
-
None
-
None
Description
The server has 1228 mentions of "_inlock" functions in 133 files, including declarations, calls, and comments. These mentions should be transitioned to take/pass a mongo::WithLock argument, instead, as defined in util/concurrency/with_lock.h, to improve static error detection.
Adoption can be incremental, per function, per file, or per subsystem. Because usage of the "*_inlock" naming convention is primarily confined to private member functions, uses of any particular such name are confined to a few files, most commonly two.
In any case, no new "_inlock" functions should be created.
Attachments
Issue Links
- is related to
-
SERVER-30748 Alternative to '_inlock' function naming
-
- Closed
-