Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-30838

Remove "_inlock" function name usage

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Won't Fix
    • None
    • None
    • None

    Description

      The server has 1228 mentions of "_inlock" functions in 133 files, including declarations, calls, and comments. These mentions should be transitioned to take/pass a mongo::WithLock argument, instead, as defined in util/concurrency/with_lock.h, to improve static error detection.

      Adoption can be incremental, per function, per file, or per subsystem. Because usage of the "*_inlock" naming convention is primarily confined to private member functions, uses of any particular such name are confined to a few files, most commonly two.

      In any case, no new "_inlock" functions should be created.

      Attachments

        Issue Links

          Activity

            People

              backlog-server-platform DO NOT USE - Backlog - Platform Team
              nathan.myers Nathan Myers
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: