-
Type: Bug
-
Resolution: Gone away
-
Priority: Major - P3
-
None
-
Affects Version/s: None
-
Component/s: Build
-
Labels:None
-
Fully Compatible
-
ALL
-
Platforms 2017-10-02, Platforms 2017-10-23
Xcode 9 adds new warnings which S2 fails.
g++ -o build/debug/third_party/s2/util/math/mathutil.o -c -Woverloaded-virtual -Werror=unused-result -Wpessimizing-move -Wredundant-move -Wno-undefined-var-template -std=c++14 -mmacosx-version-min=10.10 -fno-omit-frame-pointer -fno-strict-aliasing -ggdb -pthread -Wall -Wsign-compare -Wno-unknown-pragmas -Winvalid-pch -Werror -O0 -Wno-unused-local-typedefs -Wno-unused-function -Wno-unused-private-field -Wno-deprecated-declarations -Wno-tautological-constant-out-of-range-compare -Wno-unused-const-variable -Wno-missing-braces -Wno-inconsistent-missing-override -Wno-potentially-evaluated-expression -fstack-protector-strong -fno-builtin-memcmp -fdiagnostics-color=always -Isrc/third_party/s2 -Isrc/third_party/gflags-2.0/src -DPCRE_STATIC -DBOOST_SYSTEM_NO_DEPRECATED -DBOOST_MATH_NO_LONG_DOUBLE_MATH_FUNCTIONS -Isrc/third_party/s2 -Isrc/third_party/boost-1.60.0 -I/opt/mongodbtoolchain/v2/include -Ibuild/debug -Isrc src/third_party/s2/util/math/mathutil.cc src/third_party/s2/util/math/mathutil.cc:30:24: error: explicit instantiation of 'Round<int, double>' that occurs after an explicit specialization has no effect [-Werror,-Winstantiation-after-specialization] template int MathUtil::Round<int,double>(double x); ^ src/third_party/s2/util/math/mathutil.h:697:24: note: previous template specialization is here inline int32 MathUtil::Round<int32, double>(double x) { ^ 1 error generated.