Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-31310

Use SafeInt functions for MSVC overflow detection

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.3.1
    • Affects Version/s: None
    • Component/s: Internal Code
    • Labels:
    • Fully Compatible
    • Dev Tools 2019-07-01, Dev Tools 2019-08-26, Dev Tools 2019-09-09

      We can't use the signed specializations on MSVC2015 due to a typo in the library. That typo looks like it was fixed in MSVC2017 so we should try again after upgrading.

      Switching to SafeInt functions allows us to use templated overflow detection functions rather than supporting a fixed set of types, encoded into the function names, and providing an separate implementation for every one.

            Assignee:
            billy.donahue@mongodb.com Billy Donahue
            Reporter:
            mathias@mongodb.com Mathias Stearn
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: