[SERVER-31491] fix race in ThreadPoolTest::ThreadPoolRunsOnCreateThreadFunctionBeforeConsumingTasks - MongoDB Jira

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major - P3
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.6.0-rc1
Component/s: Concurrency
Labels:
None

Backwards Compatibility:
Fully Compatible
Operating System:
ALL
Sprint:
Repl 2017-10-23
Linked BF Score:
0

Description

In this test function, since the thread function provided to the ThreadPool relies on the Barrier, it is incorrect for the Barrier to have a shorter lifespan than the ThreadPool instance.

https://github.com/mongodb/mongo/blob/edc3dfce51b00ba3007f35cf6383efb72bf8b74e/src/mongo/util/concurrency/thread_pool_test.cpp#L256


TEST_F(ThreadPoolTest, ThreadPoolRunsOnCreateThreadFunctionBeforeConsumingTasks) {
    bool onCreateThreadCalled = false;
    std::string taskThreadName;
    ThreadPool::Options options;
    options.threadNamePrefix = "mythread";
    options.maxThreads = 1U;
    options.onCreateThread = [&onCreateThreadCalled,
                              &taskThreadName](const std::string& threadName) {
        onCreateThreadCalled = true;
        taskThreadName = threadName;
    };
 
    auto& pool = makePool(options);
    pool.startup();
    unittest::Barrier barrier(2U);
    ASSERT_OK(pool.schedule([&barrier] { barrier.countDownAndWait(); }));
    barrier.countDownAndWait();
 
    ASSERT_TRUE(onCreateThreadCalled);
    ASSERT_EQUALS(options.threadNamePrefix + "0", taskThreadName);
}

Attachments

Activity

People

Assignee:: Benety Goh

Reporter:: Benety Goh

Participants:: Benety Goh, Githook User

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: Oct 10 2017 05:07:16 PM UTC

Updated:: Dec 06 2017 09:15:57 PM UTC

Resolved:: Oct 13 2017 02:20:46 PM UTC

thread_pool_test.cpp
242	TEST_F(ThreadPoolTest, ThreadPoolRunsOnCreateThreadFunctionBeforeConsumingTasks) {
243	bool onCreateThreadCalled = false;
244	std::string taskThreadName;
245	ThreadPool::Options options;
246	options.threadNamePrefix = "mythread";
247	options.maxThreads = 1U;
248	options.onCreateThread = [&onCreateThreadCalled,
249	&taskThreadName](const std::string& threadName) {
250	onCreateThreadCalled = true;
251	taskThreadName = threadName;
252	};
253
254	auto& pool = makePool(options);
255	pool.startup();
256	unittest::Barrier barrier(2U);
257	ASSERT_OK(pool.schedule([&barrier] { barrier.countDownAndWait(); }));
258	barrier.countDownAndWait();
259
260	ASSERT_TRUE(onCreateThreadCalled);
261	ASSERT_EQUALS(options.threadNamePrefix + "0", taskThreadName);
262	}