Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-31585

Remove PeriodicBalancerSettingsRefresher that is both unused and incorrectly set up

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6.0-rc1
    • Component/s: Sharding
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Sprint:
      Sharding 2017-10-23
    • Linked BF Score:
      0

      Description

      PeriodicBalancerSettingsRefresher is currently unused because it was added as part of the intern autosplit project that didn't get finished over the summer.

      It has two problems
      1) It is instantiated incorrectly. It registers a shutdown task during sharding initialization, which can cause a crash if we're already in shutdown mode. The correct way to instantiate it it during single threaded start up of the server, where shutdown tasks can be safely registered, and then sharding initialization can simply start up the service.
      2) Furthermore it is hitting an invariant in BF-6736, the solution for which is outlined in SERVER-31537

      We're just going to remove PeriodicBalancerSettingsRefresher for now, because we don't need it and it is causing problems.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: