Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-33068

run_check_repl_dbhash.js hook exits without actually running dbhash on a replica set

    XMLWordPrintableJSON

Details

    • Fully Compatible
    • ALL
    • v3.6, v3.4
    • TIG 2018-02-12

    Description

      The changes from b9decc4 as part of SERVER-21630 introduced a bug that causes the dbhash check to always be skipped on a replica set no matter how many voting secondaries it has.

      Inside the isMultiNodeReplSet() function, the handling for when the isMaster response indicates the server is part of replica set shadows the outer hosts variable with another let declaration, thereby causing the array of connection strings to always be empty.

      function isMultiNodeReplSet(uri) {
      		 
          const mongo = new Mongo(uri);
      		 
          let hosts = [];
      		 
          const isMaster = mongo.adminCommand({isMaster: 1});
      		 
          if (isMaster.hasOwnProperty('setName')) {
      		 
              let hosts = isMaster.hosts;
      		 
              if (isMaster.hasOwnProperty('passives')) {
      		 
                  hosts = hosts.concat(isMaster.passives);
      		 
              }
      		 
          }
      		 
          return hosts.length > 1;
      		 
      }

      Note: JavaScripts that call ReplSetTest#checkReplicatedDataHashes() (e.g. from the work in SERVER-25640) aren't affected by this issue.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. SERVER-34667 data_consistency_checks.js incorrectly assumes that the config.mongos collection always exists

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is caused by

          Task - A task that needs to be done. SERVER-21630 Expand resmoke's CheckReplDBHash support to config servers and sharded replica sets

          • Major - P3 - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. SERVER-33498 ReplSetTest.checkReplicaSet fails when run against a config server replica set.

          • Minor - P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-24541 Add a test suite to test the JS hooks

          • Major - P3 - Major loss of function.
          • Closed
          related to

          Bug - A problem which impairs or prevents the functions of the product. SERVER-37197 Validation failure does not cause test to fail

          • Critical - P2 - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. SERVER-53854 checkReplicatedDataHashes() may return without throwing despite detecting a dbhash mismatch

          • Critical - P2 - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. SERVER-34178 Address lingering issues around TestData.excludedDBsFromDBHash

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              max.hirschhorn@mongodb.com Max Hirschhorn
              max.hirschhorn@mongodb.com Max Hirschhorn
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: