nia countdownlatch misuses condvars

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major - P3
    • 3.7.4
    • Affects Version/s: None
    • Component/s: Internal Code
    • None
    • Fully Compatible
    • ALL
    • Platforms 2018-03-26, Platforms 2018-04-09, Platforms 2018-04-23
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Part of the testing code in network_interface_asio_test_utils.h is a countdown latch. The latch relies on releasing writes alongside a condvar by writing to an atomic and calling notify (rather than sync'ing on the mutex the condvar is waiting on). This isn't the right way to use condvars and can be re-ordered to hang forever.

      We should drop the atomic and always take the mutex when writing to a non-atomic

            Assignee:
            Mira Carey
            Reporter:
            Mira Carey
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: