Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-33495

Command::explain must take OpMsgRequest, not dbname,cmdObj pair.

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 3.7.3
    • None
    • Internal Code
    • None
    • Fully Compatible
    • Platforms 2018-03-12

    Description

      Command::explain must take OpMsgRequest, not dbname,cmdObj pair.

      Explain synthesizes a new OpMsgRequest, then passes that to parse(),
      which then calls Command::explain which has to re-synthesize an OpMsgRequest.
      This is wasteful and produces a $db field duplication, as each synthesis injects a $db field into the request body.

      Attachments

        Activity

          People

            billy.donahue@mongodb.com Billy Donahue
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: