Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-33679

Forward declare OperationContext in read_concern_args.h

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor - P4 Minor - P4
    • 4.1.1
    • None
    • Storage
    • Fully Compatible
    • Storage NYC 2018-07-02

    Description

      read_concern_args.h does not need to include the operation_context.h. Instead of declaring the decoration getter in the header, we could move the decoration getter into the .cpp so that the header does not need to include the OperationContext.

      This can improve potential circular dependency issues because it does not make sense to have read_concern_args depend on operation_context.

      The work will include moving the decoration getter from .h to .cpp and adding read_concern_args as a dependency to all the tests/lib that use the decoration getter since the header will not have an implementation.

      Attachments

        Activity

          People

            dewal.gupta Dewal Gupta
            xiangyu.yao@mongodb.com Xiangyu Yao (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: