Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-34117

mongodb+srv uri_tests require working name resolution

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major - P3
    • Resolution: Unresolved
    • Affects Version/s: 3.6.3
    • Fix Version/s: Backlog
    • Component/s: Security, Shell
    • Labels:
    • Operating System:
      ALL
    • Steps To Reproduce:
      Hide

      $ sudo mv /etc/resolv.conf /etc/resolv.conf.back
      $ ./build/opt/mongo/client/mongo_uri_test
      ...
      [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.253+0000 2018-03-23T22:05:45.239+0000 I -        [main] 	 going to run test: srvRecordTest
      [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.254+0000 2018-03-23T22:05:45.242+0000 E -        [main] Throwing exception: Expected ::mongo::Status::OK() == (rs.getStatus()) (OK  == DNSHostNotFound Failed to look up service "_mongodb._tcp.test1.test.build.10gen.cc": Success) @src/mongo/client/mongo_uri_test.cpp:779
      [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.254+0000 2018-03-23T22:05:45.243+0000 I -        [main] FAIL: srvRecordTest	Expected ::mongo::Status::OK() == (rs.getStatus()) (OK  == DNSHostNotFound Failed to look up service "_mongodb._tcp.test1.test.build.10gen.cc": Success) @src/mongo/client/mongo_uri_test.cpp:779
      [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.254+0000 2018-03-23T22:05:45.243+0000 I -        [main] 	 DONE running tests
      [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.254+0000 2018-03-23T22:05:45.243+0000 I -        [main] **************************************************
      [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.254+0000 2018-03-23T22:05:45.243+0000 I -        [main] MongoURI                       | tests:    6 | fails:    1 | assert calls:          0 | time secs:  0.025
      [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.255+0000 	srvRecordTest	Expected ::mongo::Status::OK() == (rs.getStatus()) (OK  == DNSHostNotFound Failed to look up service "_mongodb._tcp.test1.test.build.10gen.cc": Success) @src/mongo/client/mongo_uri_test.cpp:779
      [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.255+0000 2018-03-23T22:05:45.243+0000 I -        [main] TOTALS                         | tests:    6 | fails:    1 | assert calls:          0 | time secs:  0.025
      [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.255+0000 2018-03-23T22:05:45.243+0000 I -        [main] Failing tests:
      [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.255+0000 2018-03-23T22:05:45.243+0000 I -        [main] 	 MongoURI/srvRecordTest Failed
      [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.255+0000 2018-03-23T22:05:45.243+0000 I -        [main] FAILURE - 1 tests in 1 suites failed
      [executor:cpp_unit_test:job0] 2018-03-23T22:05:45.256+0000 mongo_uri_test ran in 0.08 seconds.
      

      Show
      $ sudo mv /etc/resolv.conf /etc/resolv.conf.back $ ./build/opt/mongo/client/mongo_uri_test ... [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.253+0000 2018-03-23T22:05:45.239+0000 I - [main] going to run test: srvRecordTest [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.254+0000 2018-03-23T22:05:45.242+0000 E - [main] Throwing exception: Expected ::mongo::Status::OK() == (rs.getStatus()) (OK == DNSHostNotFound Failed to look up service "_mongodb._tcp.test1.test.build.10gen.cc": Success) @src/mongo/client/mongo_uri_test.cpp:779 [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.254+0000 2018-03-23T22:05:45.243+0000 I - [main] FAIL: srvRecordTest Expected ::mongo::Status::OK() == (rs.getStatus()) (OK == DNSHostNotFound Failed to look up service "_mongodb._tcp.test1.test.build.10gen.cc": Success) @src/mongo/client/mongo_uri_test.cpp:779 [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.254+0000 2018-03-23T22:05:45.243+0000 I - [main] DONE running tests [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.254+0000 2018-03-23T22:05:45.243+0000 I - [main] ************************************************** [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.254+0000 2018-03-23T22:05:45.243+0000 I - [main] MongoURI | tests: 6 | fails: 1 | assert calls: 0 | time secs: 0.025 [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.255+0000 srvRecordTest Expected ::mongo::Status::OK() == (rs.getStatus()) (OK == DNSHostNotFound Failed to look up service "_mongodb._tcp.test1.test.build.10gen.cc": Success) @src/mongo/client/mongo_uri_test.cpp:779 [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.255+0000 2018-03-23T22:05:45.243+0000 I - [main] TOTALS | tests: 6 | fails: 1 | assert calls: 0 | time secs: 0.025 [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.255+0000 2018-03-23T22:05:45.243+0000 I - [main] Failing tests: [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.255+0000 2018-03-23T22:05:45.243+0000 I - [main] MongoURI/srvRecordTest Failed [cpp_unit_test:mongo_uri_test] 2018-03-23T22:05:45.255+0000 2018-03-23T22:05:45.243+0000 I - [main] FAILURE - 1 tests in 1 suites failed [executor:cpp_unit_test:job0] 2018-03-23T22:05:45.256+0000 mongo_uri_test ran in 0.08 seconds.

      Description

      mongo_uri_test.cpp fails on systems without DNS resolvers.
      Specifically the valid URLs starting with `mongodb+srv://` test cases result in calling `dns::lookupSRVRecords("_mongodb._tcp." + canonicalHost)` which bombs out, on systems with (intentionally) broken DNS.

      It would be nice if that call is somehow mocked, or stubbed out, or some test responses are provided, to exercise tests on "offline" machines.

      ps. Long story short, DNS resolution is disabled on Ubuntu builders.

      pss. Longer story: I was told that Kees Cook asserted that it is a security vulnerability to James Troup, when I guess work was being done to create Launchpad PPAs, which would run untrusted code builds. James Troup asked for a proof of concept, and Kees Cook established two-way communication and got a shell up inside the builder over DNS queries to his nameserver. Ever since then DNS resolution was disabled on the Ubuntu builders. I don't know if this is true or not, but that's what I've been told.

      In the meantime, I will disable the expected success mongodb+srv:// test cases from the build.

        Attachments

          Activity

            People

            Assignee:
            backlog-server-stm Backlog - Server Tooling and Methods (STM)
            Reporter:
            xnox Dimitri John Ledkov
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

              Dates

              Created:
              Updated: