Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-34179

fix the isGenericArgument physical design

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor - P4 Minor - P4
    • 3.7.4
    • None
    • Internal Code
    • None
    • Fully Compatible
    • Platforms 2018-04-09

    Description

      CommandHelpers::isGenericArgument is currently inline in commands.h.

      Moving its definition to commands.cpp reveals that it was being called by other libraries that did not and could not declare the db/commands library in their LIBDEPS. Adding it to their LIBDEPS creates a cycle. We shouldn't tolerate such hidden library cycles.

      isGenericArgument doesn't actually depend on anything. It's just a lookup in a whitelist of strings. It's reasonable to just make a library to collect these classification predicates that identify passthrough arguments and generic arguments. This library is lower level than the dispatching, properties, parsing, and behaviors of specific executable Command that are the responsibility of the more complex db/command library.

      Attachments

        Activity

          People

            billy.donahue@mongodb.com Billy Donahue
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: