Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-34928

Address new GCC8 -Wparentheses warnings

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.0-rc0
    • Component/s: Build
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Sprint:
      Platforms 2018-05-21

      Description

      We don't want to disable this because it is a valuable warning. It is the one that warns on if (x = 5) for example. This warning only trips in third_party headers so I plan to use the same suppression style as boost added: https://github.com/boostorg/mpl/blob/3c1910797cf2a9e6f18a0a929bec95837accfb9e/include/boost/mpl/assert.hpp#L187-L206

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              redbeard0531 Mathias Stearn
              Reporter:
              redbeard0531 Mathias Stearn
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: