Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-35019

Correct interruptibility in MultiIndexBlock destructor

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • 3.7.9
    • 4.0.0-rc1, 4.1.1
    • Storage
    • Fully Compatible
    • ALL
    • v4.0
    • Storage NYC 2018-06-04
    • 64

    Description

      The MultiIndexBlock destructor should correctly instantiate an UninterruptibleLockGuard by assigning it to a variable name that stays in scope.

      Original text:
      Both renameCollection and compact commands use a MultiIndexBlock to rebuild indexes, which is not resilient to lock interrupts, but handles interruptibility through periodic calls to checkforInterrupt().

      An UninterruptibleLockGuard should be used in both commands, similar to what is already done for the createIndexes command.

      the jstestfuzz_interrupt_replication test suite has found that interrupting these commands can result in an fassert when cleaning up partially built indexes. For unknown reasons, the existing UninterruptibleLockGuard in the destructor does protect against this failure, and can just be removed.

      Attachments

        Issue Links

          Activity

            People

              louis.williams@mongodb.com Louis Williams
              louis.williams@mongodb.com Louis Williams
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: