Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-35287

File-global variables in oplog.cpp should be decorations on ServiceContext

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.1.1
    • Affects Version/s: None
    • Component/s: Replication
    • Labels:
      None
    • Fully Compatible

      oplog.cpp contains several file-scoped variables that ought instead exist per instance of ServiceContext. It also contains a few now-unused global variables, which should be removed. This ticket's task is to remove the disused variables and move the remainder into a decoration on the ServiceContext.

      The variables to remove are:

      • lastSetTimestamp
      • newTimestampNotifier

      The variables to move to a decoration are:

      • _localOplogCollection
      • hashGenerator
      • newOpMutex
      • _oplogCollectionName

       

            Assignee:
            schwerin@mongodb.com Andy Schwerin
            Reporter:
            schwerin@mongodb.com Andy Schwerin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: