Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-35970

Use regular Locker during storage engine initialization

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.8.0
    • Affects Version/s: None
    • Component/s: Storage
    • None
    • Fully Compatible
    • Execution Team 2020-09-21, Execution Team 2020-10-05

      LockerNoop is used both in production and unit testing. Certain LockerNoop functions return static values to facilitate unit tests. It is dangerous to use LockerNoop for both purposes, in case a naive test framework (LockerNoop) change introduces a production problem.

      A new barebones Locker implementation should be created just for production, and LockerNoop updated accordingly.

      Should also look at other Noop classes, to determine whether there are other crossovers between testing and production that could become similarly unsafe – like OperationContextNoop.

      I'm unsure whether LockerNoop should ultimately be the just for test or just for production version, once we have a new implementation. It's a naming convention choice.

            Assignee:
            gregory.wlodarek@mongodb.com Gregory Wlodarek
            Reporter:
            dianna.hohensee@mongodb.com Dianna Hohensee (Inactive)
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: