Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-36243

Take advantage of c++14 sized delete facilities in tc_malloc

    • Type: Icon: Task Task
    • Resolution: Duplicate
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Internal Code, Performance
    • None
    • Dev Tools 2019-02-25, Dev Tools 2019-03-11, Dev Tools 2019-03-25
    • 16

      Google reported substantial performance improvement by adopting sized delete.

       

      Tasks:

      • Ensure we are building tcmalloc in a way that enables sized delete
      • Ensure we are passing the c++ flags to tell the compiler to use it automatically where it can
      • Make sure all of the Document/Value allocations (including RCString) can use sized delete
        • May need to make second argument to RCString::operator new() a different type (currently size_t)
      • Find the best way to expose a sized free equivalent for code using malloc/relloc/free
        • Teach SharedBuffer to used sized free
        • Teach WiredTiger to use sized free for any allocations that know their own size (WT_UPDATE already identified as an important case)

            Assignee:
            henrik.edin@mongodb.com Henrik Edin
            Reporter:
            mathias@mongodb.com Mathias Stearn
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: