Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-36493

Invalidate in-memory prepared transaction state on replication rollback

    XMLWordPrintable

    Details

    • Backwards Compatibility:
      Fully Compatible
    • Sprint:
      Repl 2018-10-08, Repl 2018-10-22, Repl 2018-11-05, Repl 2018-11-19, Repl 2018-12-03, Repl 2018-12-17

      Description

      Before calling recoverToStableTimestamp, we must abort any prepared transactions. This will require us to iterate through all active sessions and check if there is a prepared transaction on that session. If there is, we must abort the storage transaction. We will not update ServerTransactionMetrics or make any writes to the transactions table.

      There are several scenarios that we have to consider, but in each it should be safe to abort the prepared transaction and reconstruct the state during startup recovery.

      For the following examples, prepare timestamp = the oldest prepare timestamp whose corresponding commit/abort oplog entry is not majority committed.

      Case #1: stable timestamp is before the prepare timestamp

      When we rollback to a stable timestamp that is before the prepare timestamp, we can safely clear the prepared transaction states because we will reconstruct the prepared transaction and its commit/abort if one exists. We are not writing to the transactions table and will call the corresponding functions in TransactionParticipant (prepareTransaction, commitPreparedTransaction, and abortActiveTransaction) during startup recovery. Therefore, the oldestActiveOplogEntryOpTimes and oldestNonMajorityCommittedOpTimes will be be re-populated accordingly.

      Case #2: stable timestamp is at the prepare timestamp

      Since we will be reconstructing prepared transactions even if the stable timestamp is AT the prepare timestamp, this case is the same as Case #1.

      Case #3: stable timestamp is after the prepare timestamp.

      The stable timestamp would only advance farther than the prepare timestamp if its corresponding commit/abort oplog entry has been majority committed. This would mean that neither the prepare or commit/abort should be rolled back since the common point would have to be after the majority commit point. In this case, we technically should no longer have information about the prepared transaction, so its safe to clear the data structure. If another prepared transaction exists, we would defer to Case #1 or Case #2.

      We already have a function that invalidates sessions in session_catalog_mongod that is called in OpObserverImpl::onReplicationRollback. This is used to invalidate sessions that had operations that would have been rolled back. Similarly we would create a function called invalidateSessionsWithPreparedTransactions that would scan all sessions and call txnParticipant->shutdown() on prepared transactions.

      Currently, the shutdown() function is only used on shutdown and aborts the storage transaction of any transaction. We will modify this function to have a flag isInRollback so we know to only abort prepared transactions if this is set to true. We will also clear the oldestActiveOplogEntryOpTimes and oldestNonMajorityCommittedOpTimes in this function.

      Finally, we will have to decide how to properly update ServerTransactionsMetrics during a rollback. For example, if we call abortActiveTransaction on a prepared transaction, it will increment the count of both totalAborted and totalPreparedThenAborted.

      Since we cannot write an integration test for this ticket until the state transition work is in, we will unit test the shutdown and invalidateSessionsWithPreparedTransactions functions.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pavithra.vetriselvan Pavithra Vetriselvan
              Reporter:
              judah.schvimer Judah Schvimer
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: