Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-3671

change VERSION to PDFILE_VERSION

XMLWordPrintableJSON

    • Type: Icon: Bug Bug
    • Resolution: Done
    • Priority: Icon: Minor - P4 Minor - P4
    • 2.1.0
    • Affects Version/s: None
    • Component/s: Build
    • None
    • Environment:
      Debian Linux Squeeze 32bit
    • ALL

      Seems to be some comparability with linking against your library when using autoconf as autoconf defines VERSION.

      In file pch.h on lines 106

      // pdfile versions
      const int VERSION = 4;

      Its bad practice to declare a constant as common as VERSION without even doing a #ifdef before.

      My suggestion would be to rename VERSION to PDFILE_VERSION.

            Assignee:
            eliot Eliot Horowitz (Inactive)
            Reporter:
            adammagaluk Adam Magaluk
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: