Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-37219

DocumentSourceOut::spill() and helpers should take arguments by rvalue-reference instead of const-ref

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 4.1.4
    • None
    • Aggregation Framework
    • None
    • Fully Compatible
    • Query 2018-09-24

    Description

      Doing so would allow a 'std::move' to actually do a move instead of a copy - since a std::move on a const reference compiles but does not actually allow a move. Theoretically this will speed things up, but there weren't any reliable results in some performance tests I ran.

      Attachments

        Activity

          People

            charlie.swanson@mongodb.com Charlie Swanson
            charlie.swanson@mongodb.com Charlie Swanson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: