DocumentSourceOut::spill() and helpers should take arguments by rvalue-reference instead of const-ref

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Major - P3
    • 4.1.4
    • Affects Version/s: None
    • Component/s: Aggregation Framework
    • None
    • Fully Compatible
    • Query 2018-09-24
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Doing so would allow a 'std::move' to actually do a move instead of a copy - since a std::move on a const reference compiles but does not actually allow a move. Theoretically this will speed things up, but there weren't any reliable results in some performance tests I ran.

            Assignee:
            Charlie Swanson
            Reporter:
            Charlie Swanson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: