-
Type: Improvement
-
Resolution: Done
-
Priority: Major - P3
-
Affects Version/s: None
-
Component/s: Index Maintenance
-
None
These are just minor code cleanups - wanted to track somewhere. Anyone feel free to add stuff (I will if I see more issues), though major architectural changes should probably be separate tickets.
ss << " parent: " << this->parent.toString() << endl;
ss << " nextChild: " << this->parent.toString() << endl;
logging nextChild incorrectly.
BTREE(this->nextChild)>parent.writing() = this>parent;
BTREE(this->nextChild)>parent.writing() = this>parent;
//(static_cast<DiskLoc>(this->nextChild).btree<V>())>parent.writing() = this>parent;
We are signaling write intent and assigning twice
// Because lchild is a descendant of thisLoc, updating thisLoc will
// not not affect packing or keys of lchild and kn will be stable
// during the following setInternalKey()
Double not
// make a this->new this->parent if we were the root
???
operator DiskLoc() const
{ // endian if( isNull() ) return DiskLoc(); unsigned a = *((unsigned *) (_a-1)); return DiskLoc(a >> 8, ofs); }Should return const DiskLoc