Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-38062

Add assert.commandWorked() to commands in read_pref_cmd.js

    XMLWordPrintable

    Details

    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Backport Requested:
      v4.0, v3.6, v3.4
    • Sprint:
      Sharding 2018-12-17
    • Linked BF Score:
      40

      Description

      Multiple times in read_pref_cmd.js, the test marches forward assuming commands worked without actually verifying that they work. This can lead to race conditions and unlikely bugs, especially on slow machines.

      These lines in particular need to be changed as part of the linked BF, but we should add the assertion to other commands as well.

        Attachments

          Activity

            People

            Assignee:
            blake.oler Blake Oler
            Reporter:
            blake.oler Blake Oler
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: