Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-38144

Remove write concern "majority" overrides for change streams test suites

    • Type: Icon: Improvement Improvement
    • Resolution: Won't Fix
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: Querying, Replication
    • Labels:
    • Repl 2018-12-17

      The change streams test suites all utilize the set_read_and_write_concerns.js override as a means to override write concern to "majority" on all commands run in their tests. This was presumably added originally to make sure that writes done in a test would be majority committed so as to ensure they would be visible in subsequent change stream queries (which only return majority committed data). Hopefully the reliance on "majority" write concern has been superseded by sufficient usage of assert.soon to wait for changes to appear in a stream. Getting rid of these overrides would be a nice cleanup and also make it more explicit when tests do and don't rely on majority write guarantees.

            william.schultz@mongodb.com William Schultz (Inactive)
            william.schultz@mongodb.com William Schultz (Inactive)
            0 Vote for this issue
            3 Start watching this issue