Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-39117

Must deep-copy objects in ops array in txn_override.js

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Gone away
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Replication
    • Labels:
    • Operating System:
      ALL
    • Sprint:
      Repl 2019-01-28, Repl 2019-02-11, Repl 2019-02-25, Repl 2019-03-11, Repl 2019-03-25, Repl 2019-04-08
    • Linked BF Score:
      18

      Description

      When pushing an object onto the 'ops' array in continueTransaction, we currently do not deep-copy it. This means that if a test modifies one of the objects it uses, if we retry the transaction the retry will use the modified objects. We should do a deep copy.

      Note we have a deepCopyObject method in jstests/concurrency/fsm_libs/fsm.js which might be appropriate for this.

        Attachments

          Issue Links

          duplicates

          Task - A task that needs to be done. SERVER-38937 Unify txn_override.js and auto_retry_on_network_error.js

          • Major - P3 - Major loss of function.
          • Closed
          is related to

          Task - A task that needs to be done. SERVER-38936 Create unittests for txn_override.js

          • Major - P3 - Major loss of function.
          • Closed

            Activity

              People

              Assignee:
              judah.schvimer Judah Schvimer
              Reporter:
              matthew.russotto Matthew Russotto
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: