Details
Description
Due to a typo in the PlanStage::dispose() invariant it can never be evaluated to false.
src/mongo/db/exec/plan_stage.h:271:62: warning: self-comparison always evaluates to true [-Wtautological-compare]
|
|
|
::mongo::invariantWithLocation((!_opCtx !_opCtx || opCtx == opCtx", "src/mongo/db/exec/plan_stage.h", 271);
|
The opCtx == opCtx condition should be opCtx == _optCtx.
Note that there is a task SERVER-37453 to delete PlantExecutor::dispose() method and its friends, so we may not need to fix this issue if the dispose() code is being removed in next sprint.
Attachments
Issue Links
- depends on
-
SERVER-47598 locally installed mongodbtoolchains can affect remote icecream builds
-
- Closed
-
- is related to
-
-
- Closed
-
-
SERVER-37453 Delete PlanStage::dispose()
-
- Closed
-