Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-39591

RecoveryUnit::waitUntilDurable() should invariant against callers holding locks

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.1
    • Component/s: Storage
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Sprint:
      Storage NYC 2019-05-20, Execution Team 2019-11-18

      Description

      MMAP's implementation had an invariant, but the other storage engine implementations appear not to have any.

      Locks should not be held while waitUntilDurable is called for two reasons: 1) it can take a long time to make data durable, so a lock should not be held that long for I/O; 2) we could run out of tickets and the lock that the caller has could stop the rest of the system from freeing up enough for he durability task to get a ticket, thus a ticketing deadlock.

      This requires fixing the failpoint in index builds that calls waitUntilDurable() with locks, curtesy of SERVER-39585 to unblock other work

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: