Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-39754

Rewrite `txn_two_phase_commit_killop.js` and `txn_two_phase_commit_failover.js` as unit-tests

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Sharding
    • Labels:

      Description

      The txn_two_phase_commit_killop.js and txn_two_phase_commit_failover.js tests are inscrutable and rely on an exact number of times certain strategically placed failpoints are hit and show up in the log.

      These tests would be much better if implemented as unit-tests of the TransactionCoordinator's logic.

        Attachments

          Issue Links

          is duplicated by

          Task - A task that needs to be done. SERVER-39422 Refactor common parts of txn_two_phase_commit_*.js tests into sharded_transactions_helpers.js library

          • Major - P3 - Major loss of function.
          • Closed
          related to

          Task - A task that needs to be done. SERVER-43529 Remove TODO listed in SERVER-39754

          • Major - P3 - Major loss of function.
          • Open

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: