Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-40386

Audit call sites of commitTransaction_forTesting() and abortTransaction_forTesting() to make sure they do not ignore server response

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.1.14, 4.2.0-rc1
    • Affects Version/s: None
    • Component/s: Replication
    • Labels:
      None
    • Fully Compatible
    • v4.2
    • Repl 2019-05-06, Repl 2019-06-03, Repl 2019-06-17

      As a part of SERVER-36728, we replaced the abortTransaction() helper with abortTransaction_forTesting(), which does not ignore server errors. However, in a majority of our tests, we do not use the response.

      We should either assert that the abort succeeded or that the command failed with NoSuchTransaction to account for transactions implicitly aborted by the server.

      We should also make sure we aren't using commitTransaction() or abortTransaction() in our tests unintentionally.

            Assignee:
            lingzhi.deng@mongodb.com Lingzhi Deng
            Reporter:
            pavithra.vetriselvan@mongodb.com Pavithra Vetriselvan
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: