Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-40633

Audit all uses of _replExecutor and check shutdown in scheduled tasks

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major - P3
    • Resolution: Won't Fix
    • None
    • None
    • Replication
    • None
    • Service Arch
    • ALL
    • 5

    Description

      After SERVER-39965, a scheduled task may run on the caller's thread rather than in the thread pool on shutdown. Since the scheduled task can acquire the replication mutex which may have been held by the caller, a deadlock will occur. Heartbeat schedule is an example.

      Due to how heartbeat callbacks is tracked in _heartbeatHandles, it may not be straightforward to check the status and return before acquiring the lock.

      Heartbeat cancellation has also to be considered when working on this ticket. When the heartbeat is cancelled while it's already running or scheduled but hasn't run yet, the ownership of the callback should be clarified. Currently, it's the cancelled callback's job to clear itself.

      Attachments

        Issue Links

          has to be done after

          Bug - A problem which impairs or prevents the functions of the product. SERVER-40769 Untrack heartbeat callbacks on heartbeat cancellation

          • Major - P3 - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. SERVER-40499 ReplicationCoordinatorImpl::_handleHeartbeatResponse should check for cancelation before taking mutex

          • Major - P3 - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. SERVER-40795 Always execute ThreadPoolTaskExecutor callbacks on thread pool threads

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-39965 Make OutOfLineExecutor return a Status from schedule()

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              backlog-server-servicearch Backlog - Service Architecture
              siyuan.zhou@mongodb.com Siyuan Zhou
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: