Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-40664

Fix upload.py script to use Python3 for clang-format checking

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major - P3
    • Resolution: Gone away
    • None
    • None
    • Tools
    • None
    • ALL
    • Hide

      $ python3 ~/kernel-tools/codereview/upload.py --check-clang-format --clang-format-script=buildscripts/clang_format.py -y -m just-testing --rev=`git merge-base HEAD origin/master` --nojira
      Checking Clang-Format for patch
      Got error status from ['python', 'buildscripts/clang_format.py', 'lint-patch', '/var/folders/hp/vs7bml0j0jz8xp57r_4bw34m0000gr/T/tmpvr7b1ln5']:

      Show
      $ python3 ~/kernel-tools/codereview/upload.py --check-clang-format --clang-format-script=buildscripts/clang_format.py -y -m just-testing --rev=`git merge-base HEAD origin/master` --nojira Checking Clang-Format for patch Got error status from ['python', 'buildscripts/clang_format.py', 'lint-patch', '/var/folders/hp/vs7bml0j0jz8xp57r_4bw34m0000gr/T/tmpvr7b1ln5'] :
    • Storage NYC 2019-04-22

    Description

      The upload.py script still calls uses a python command to run clang-format, but that no longer works now clang-format needs python3.

      Attachments

        Activity

          People

            geert.bosch@mongodb.com Geert Bosch
            geert.bosch@mongodb.com Geert Bosch
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: