Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-40784

Change document shard key code should check commitTransaction response's writeConcern status

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.1.11
    • Affects Version/s: None
    • Component/s: Sharding
    • Labels:
      None
    • Fully Compatible
    • Sharding 2019-05-06

      Currently, the client's writeConcern is passed on commitTransaction, since that is the behavior of TransactionRouter::commitTransaction.

      TransactionRouter::commitTransaction stops processing responses and returns the last response on seeing a response with a writeConcern error.

      However, unlike the ClusterCommitTransactionCmd, which just passes the return value of TransactionRouter::commitTransaction to the client, the change shard key code checks the response status and continues with the write batch. The code should probably also check the writeConcern status and report it in the correct format for writeConcern errors for batched writes.

            Assignee:
            janna.golden@mongodb.com Janna Golden
            Reporter:
            esha.maharishi@mongodb.com Esha Maharishi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: