Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-41038

The results of git describe for MONGO_VERSION vary by git version

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Critical - P2 Critical - P2
    • 4.0.10, 4.1.11
    • Affects Version/s: None
    • Component/s: Build
    • Labels:
    • Minor Change
    • ALL
    • v4.0, v3.6, v3.4, v3.2
    • Dev Tools 2019-05-20

      Newer versions of git have changed the way the number of abbrev characters are computed.

      The result is that MONGO_VERSION may be computed differently in the compile expansions depending on what git version is running locally.

      This manifested in the embedded builders, where the build of the SDK ran on a machine that generated a 10 character abbrev string, but a consuming task ran on a machine with an older version of git that expected only 7. Since the filenames didn't match, the consuming task failed:

      There seems to be another issue as well, where even though the same machine image is used, sometimes we get a 10 digit abbrev, and sometimes 7.

      On the same commit:

      So this suggests that perhaps we have a gitconfig or inconsistent git versions across the macOS fleet.

      In any event, we should hardcode an abbrev size in all locations where we invoke git describe.

            mathew.robinson@mongodb.com Mathew Robinson (Inactive)
            andrew.morrow@mongodb.com Andrew Morrow (Inactive)
            0 Vote for this issue
            4 Start watching this issue