Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-41571

jsontests.cpp is hard to read and maintain

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor - P4 Minor - P4
    • 4.3.1
    • 4.3 Desired
    • Internal Code
    • None
    • Fully Compatible
    • Dev Tools 2019-06-17
    • 0

    Description

      jsontests.cpp uses inheritance to parse each string that it wants to test.

      This is really wasteful and makes it difficult to see the differences among the tests in a group. The tests don't share common code. The file is about 3000 lines, and doesn't need to be.

      I'd like to see us make some progress toward phasing out this kind of boilerplate-dominated testing.

      The test for SERVER-8544 was too hard to add.

      Attachments

        Activity

          People

            billy.donahue@mongodb.com Billy Donahue
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: