Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-41598

Elevate a mock storage engine implementation out of a particular unit test to make it generically usable

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Won't Do
    • None
    • None
    • Storage
    • None

    Description

      catalog_control_test.cpp and kv_drop_pending_ident_reaper_test.cpp both create mock storage engines. It would be useful to move and merge those implementations into a mock storage engine file, so that other tests can utilize the same implementation rather than continuing to write mocks per file.

      We should also explore why mocks were created instead of using the devnull storage engine. From a cursory examination, it seems arguable that the dev null engine is helpful for perf. A mock that does special actions, like one of the mocks does, would not be good for perf testing. Perhaps update the devnull engine to specify it is only used for perf reasons now? If that is true.

      Attachments

        Issue Links

          Activity

            People

              backlog-server-execution Backlog - Storage Execution Team
              dianna.hohensee@mongodb.com Dianna Hohensee
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: