Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-41625

RollbackTest fixture runs data consistency checks twice when it stops

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor - P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.4
    • Component/s: Replication
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Sprint:
      Repl 2020-01-27, Repl 2020-02-10

      Description

      The RollbackTest fixture runs replica set data consistency checks explicitly inside its stop() method. We subsequently call stopSet on the underlying ReplSetTest used by the RollbackTest. Since the completion of SERVER-25640, we will run data consistency checks by default inside stopSet. This causes us to run data consistency checks twice when stopping an instance of RollbackTest. These extra checks are redundant and can slow down test execution. We can likely remove the extra data consistency check in RollbackTest.stop() and rely on the checks done by ReplSetStep.stopSet().

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ryan.timmons Ryan Timmons
              Reporter:
              william.schultz William Schultz (Inactive)
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: