Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-41879

cpplint.py rejects "asm volatile"

    XMLWordPrintableJSON

Details

    • Icon: Bug Bug
    • Resolution: Gone away
    • Icon: Major - P3 Major - P3
    • None
    • None
    • Tools
    • None
    • Server Development Platform
    • ALL

    Description

      cpplint.py wants to prohibit "volatile" variable types but allow the volatile keyword on a line of inline assembly. However, it only allows __asm__ volatile, it rejects asm volatile.

      Let's update the check in CheckForMongoVolatile() in cpplint.py. Now, it bans volatile unless it sees __asm__ specifically. Instead, it should ban volatile unless the line matches the _MATCH_ASM regex.

      Attachments

        Activity

          People

            backlog-server-devplatform [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
            jesse@mongodb.com A. Jesse Jiryu Davis
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: