cpplint.py rejects "asm volatile"

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Gone away
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Tools
    • None
    • Server Development Platform
    • ALL
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      cpplint.py wants to prohibit "volatile" variable types but allow the volatile keyword on a line of inline assembly. However, it only allows __asm__ volatile, it rejects asm volatile.

      Let's update the check in CheckForMongoVolatile() in cpplint.py. Now, it bans volatile unless it sees __asm__ specifically. Instead, it should ban volatile unless the line matches the _MATCH_ASM regex.

              Assignee:
              [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
              Reporter:
              A. Jesse Jiryu Davis
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: