Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-42090

Make ordering of OR branches stable in query data access planning

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • 4.3.1
    • Querying
    • None
    • Fully Compatible
    • Query 2019-08-12, Query 2019-08-26, Query 2019-09-09

    Description

      The ordering of the branches in an OR stage should not affect the performance of the plan, since all branches must be executed in full in order for the plan to complete. However, the order of the children can matter for plan selection, e.g. for users who are affected by SERVER-20616. The ordering chosen by the access planner is not only arbitrary right now, but it is not stable. That is, multiple executions of the same query could theoretically choose a different OR ordering. The improvement tracked by this ticket is to ensure that the planner always chooses a particular, if arbitrary, ordering.

      The ordering chosen right now is a function of the sort by TagComparison done in preparation for access planning. The problem is that two very different MatchExpression nodes can easily sort equally under this comparison. In particular, $and MatchExpression nodes can sort equally. To fix this, we can refine the comparator function to consider two nodes' children if they would otherwise be considered equal.

      Attachments

        Activity

          People

            david.storch@mongodb.com David Storch
            david.storch@mongodb.com David Storch
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: