Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-42624

reformat error_codes.err as error_codes.yml

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 4.3.1
    • None
    • Internal Code
    • None
    • Fully Compatible
    • Dev Tools 2019-09-09, Dev Tools 2019-09-09

    Description

      This file is very messy and should get a once-over.

      `error_code` is a function call, with inconsistent formatting.
      It's easier to review data tables than a sequence of function calls.

      Place the error code integer first, so table lines up better, and the contiguous integer sequence is emphasized. Doing so makes it clear that the array is mostly sorted with some errors. So sort it as well.

      Reformat the error_class definitions as a big json object, with one code per line for maximum diff friendliness. Existing formatting is inconsistently bin packed.

      Also:

      Remove semicolons from error_codes calls.

      Remove trailing space from integer codes.

      Consistently use single-quotes.

      Sort the ErrorCode definitions.

      Attachments

        Activity

          People

            billy.donahue@mongodb.com Billy Donahue
            billy.donahue@mongodb.com Billy Donahue
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: