Remove unused/duplicate definition of UnshardedCollection in metadata_manager.cpp

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Major - P3
    • 4.3.1
    • Affects Version/s: None
    • Component/s: Sharding
    • None
    • Fully Compatible
    • Sharding 2019-08-26
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      There are identical definitions of the UnshardedCollection class in metadata_manager.cpp and collection_sharding_state.cpp, and I think only the one in collection_sharding_state.cpp is actually used:

      class UnshardedCollection : public ScopedCollectionMetadata::Impl {
      public:
          UnshardedCollection() = default;
      
          const CollectionMetadata& get() override {
              return _metadata;
          }
      
      private:
          CollectionMetadata _metadata;
      };
      
      const auto kUnshardedCollection = std::make_shared<UnshardedCollection>();
      

            Assignee:
            Esha Maharishi (Inactive)
            Reporter:
            Esha Maharishi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: