Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-42791

Remove unused/duplicate definition of UnshardedCollection in metadata_manager.cpp

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 4.3.1
    • None
    • Sharding
    • None
    • Fully Compatible
    • Sharding 2019-08-26

    Description

      There are identical definitions of the UnshardedCollection class in metadata_manager.cpp and collection_sharding_state.cpp, and I think only the one in collection_sharding_state.cpp is actually used:

      class UnshardedCollection : public ScopedCollectionMetadata::Impl {
      public:
          UnshardedCollection() = default;
       
          const CollectionMetadata& get() override {
              return _metadata;
          }
       
      private:
          CollectionMetadata _metadata;
      };
       
      const auto kUnshardedCollection = std::make_shared<UnshardedCollection>();
      

      Attachments

        Activity

          People

            esha.maharishi@mongodb.com Esha Maharishi (Inactive)
            esha.maharishi@mongodb.com Esha Maharishi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: