Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-42839

Make storage_engine.h functions that throw / fassert / invariant pure virtual functions

    • Type: Icon: Improvement Improvement
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 4.3.1
    • Affects Version/s: None
    • Component/s: Storage
    • Labels:
    • Fully Compatible
    • Execution Team 2019-10-07

      It doesn't make sense to throw/fassert/invariant in functions declared in storage_engine.h anymore, because storage_engine_impl.h always overrides them.

      For example in storage_engine.h,
      https://github.com/mongodb/mongo/blob/c0ca6049bad1bf918e46d83cddab134b7441abf7/src/mongo/db/storage/storage_engine.h#L398-L423

      and correspondingly in storage_engine_impl.h
      https://github.com/mongodb/mongo/blob/c0ca6049bad1bf918e46d83cddab134b7441abf7/src/mongo/db/storage/storage_engine_impl.h#L136-L140

            Assignee:
            evgeni.dobranov@mongodb.com Evgeni Dobranov
            Reporter:
            dianna.hohensee@mongodb.com Dianna Hohensee (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: