Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-42998

Make multiSyncApply non-configurable

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 4.3.1
    • None
    • Replication
    • None
    • Fully Compatible
    • Repl 2019-10-07, Repl 2019-10-21

    Description

      SyncTail::oplogApplication takes a callback function, which is normally the free function multiSyncApply. This callback takes a pointer to a SyncTail and calls methods on it. This is the most tangled part of the control flow.

      The only reason to make this function a configurable callback is so tests can override it with a no-op function in order to disable oplog application. This could be done more simply with a configuration option or by subclassing, leaving the main codepath more clear. Convert multiSyncApply (which will have been renamed to applyGroup and moved into OplogApplier) from a free function to a method of OplogApplier.

      Attachments

        Activity

          People

            mihai.andrei@mongodb.com Mihai Andrei
            jesse@mongodb.com A. Jesse Jiryu Davis
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: