Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-43100

Remove CoordinateCommitReturnsNoneIfCoordinatorWasRemoved unit test

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.1, 4.2.7
    • Component/s: Sharding
    • Labels:
    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Backport Requested:
      v4.2
    • Sprint:
      Sharding 2019-09-09
    • Linked BF Score:
      0

      Description

      The unit test is no longer valid after SERVER-42772, because now the coordinator is removed from the catalog asynchronously.

      However, we could add some more test coverage:

      • That a coordinator is removed from the catalog on completion. From a quick search, I only foundĀ one unit test of this, and it is for when the coordinator is canceled. We could add coverage for the coordinator completing successfully or with an error.
      • That calling TransactionCoordinatorService::coordinateCommit for a lsid and txnNumber whose coordinator has completed either returns boost::none (because the coordinator has already been removed) or a ready future (the coordinator has yet to be removed).

        Attachments

          Activity

            People

            Assignee:
            cheahuychou.mao Cheahuychou Mao
            Reporter:
            esha.maharishi Esha Maharishi
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: