Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-43256

Fix incorrect uses of assert.soon and make hang-analysis call exit

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: Backlog
    • Fix Version/s: 4.3.1
    • Component/s: Internal Code
    • Labels:
      None

      Description

      A number of places use assert.soon as a retry mechanism (e.g. ssl_test.js), and at least one test (index_delete.js) runs assert.soon in a try/finally block to capture better error messages.

      ↑ looks like this:

          try {
              assert.soon(function() {
                  return checkProgram(serverPID).alive &&
                      (0 === _runMongoProgram.apply(null, clientArgv));
              }, "connect failed", connectTimeoutMillis);
          } catch (ex) {
              return false;
          } finally {
              _stopMongoProgram(this.port);
          }
      

      In the cases where assert.soon fails due to timeout, we want to instead run hang-analysis and exit rather than returning control to the caller.

      (Comment from Robert: I think assert.soon almost always fails due to a timeout. What's the reason for exiting in this case?)

      Uses of assert.soon are pervasive in jstests so do a best-effort fix here. Could modify assert.soon in a patch-build to throw immediately and any test that doesn't fail is likely using it incorrectly.

      If there are more than (say) 3-4 cases of using assert.soon as a retry mechanism, create a helper assert.retry method (name/location tbd) that has a similar signature to assert.soon but doesn't call hang-analyzer or barf if the callback is never truthy and instead returns a [success, error] array where success is the last result of the callback and error is any errors thrown by the callback. (Exact signature tbd depending on how it's used by callers of extant assert.soon.)

      Finally, once this is done, modify existing callers of the hang-analyzer (probably just assert.soon) to call exit after running hang-analysis.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: