Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-43640

The user cache invalidator invarianting in it's dtor decreases debuggability

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.1, 4.2.2
    • Component/s: Security
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Backport Requested:
      v4.2, v4.0, v3.6
    • Sprint:
      Security 2019-10-21
    • Case:

      Description

      The user cache invalidator currently invariant's in its dtor.  See

      UserCacheInvalidator::~UserCacheInvalidator() {
            invariant(globalInShutdownDeprecated());
            // Wait to stop running.
            wait();
      }
      

      The problem with this is that we make a UserCacheInvalidator in runMongosServer as part of mongos' startup. And then if anything goes wrong, before global shutdown, we crash in that invariant. That prevents us from returning an error code, letting an exception with a stack bubble up, etc.

        Attachments

          Activity

            People

            Assignee:
            spencer.jackson Spencer Jackson
            Reporter:
            jason.carey Jason Carey
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: