The user cache invalidator invarianting in it's dtor decreases debuggability

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major - P3
    • 4.3.1, 4.2.2
    • Affects Version/s: None
    • Component/s: Security
    • None
    • Fully Compatible
    • ALL
    • v4.2, v4.0, v3.6
    • Security 2019-10-21
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      The user cache invalidator currently invariant's in its dtor.  See

      UserCacheInvalidator::~UserCacheInvalidator() {
            invariant(globalInShutdownDeprecated());
            // Wait to stop running.
            wait();
      }
      

      The problem with this is that we make a UserCacheInvalidator in runMongosServer as part of mongos' startup. And then if anything goes wrong, before global shutdown, we crash in that invariant. That prevents us from returning an error code, letting an exception with a stack bubble up, etc.

              Assignee:
              Spencer Jackson
              Reporter:
              Mira Carey
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: