We attempted to enable the link-time ODR detector in the past. The flag to do so --detect-odr-violations is spammed all over the place in the CI configuration (though we only ever really intended to turn it on for one builder). Unfortunately, due to a logic error, the logic to enable the actual link time flag is broken, and the required linker flag is never enabled. When that error is fixed, and we apply the flag, we do find ODR violations.

We should migrate the ODR detection to a single builder, remove the spamming of the flag through the CI system, fix the logic error, and then address any found ODR violations.