Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-43762

tighten the overload set for BSONObjBuilder::appendNumber

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major - P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 4.3 Required
    • Component/s: Internal Code
    • Labels:
      None
    • Sprint:
      Dev Tools 2019-11-04, Dev Tools 2019-12-02, Dev Tools 2019-12-16 real
    • Linked BF Score:
      70

      Description

      In SERVER-9763 we improved the overload set for BSONObjBuilder::append.

      We still have the same trouble with BSONObjBuilder::appendNumber.
      Certain flags and compiler versions will complain about ambiguity, MacOS clang debug, argument is uint64_t, overload set is (int,double,size_t,long long). We probably need to get size_t out of the overload set.

      uint64_t should be size_t but isn't?

      This causes wasteful BFs:
      BF-14896
      BF-11187
      BF-5725

      and cleanup work:
      https://github.com/mongodb/mongo/commit/be20a34cf0af56cccc378861abb43e528daacea5

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                billy.donahue Billy Donahue
                Reporter:
                billy.donahue Billy Donahue
                Participants:
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: